Fixed typo in constants.py #199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgiatai <[email protected]>
Signed-off-by: georgiatai <[email protected]>
riscv_config/constants.py
Outdated
| @@ -8,7 +8,7 @@ | |||
| platform_schema = os.path.join(root, 'schemas/schema_platform.yaml') | |||
| custom_schema = os.path.join(root, 'schemas/schema_custom.yaml') | |||
| Zvl_extensions = [ | |||
| "Zvl32b", "Zvl64b", "Zvl128b", "Zvl256b", "Zve512b", "Zvl1024b" | |||
| "Zvl32b", "Zvl64b", "Zvl128b", "Zvl256b", "Zvl512b", "Zvl1024b", "Zvl2048b" | |||
There was a problem hiding this comment.
Doesn't look like Zvl2048b is an actual extension. From the "Zvl*: Minimum Vector Length Standard Extensions" section of the spec:
There was a problem hiding this comment.
Spike is, however, configured with Zvl*, including Zvl2048b. If it is not included here, then when using riscof, we will be unable to configure with that VLEN. Should Zvl2048b still be included in here in this case, despite not being on the Table 60?
There was a problem hiding this comment.
There is also a quote from the spec:
Longer vector length extensions should follow the same pattern.
Thus I think it would be fine to include longer Zvl extensions, and beneficial to match spike.
Signed-off-by: georgiatai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typo of
Zve512btoZvl512binZvl_extensions.