Skip to content

Rename overlaycall/overlaydata to overlay_call/overlay_data in RT engine #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edward-jones
Copy link
Contributor

This updates the runtime engine to use overlay_call and overlay_data
in the overlay attributes instead of overlaycall and overlaydata
respectively.

This updates the runtime engine to use overlay_call and overlay_data
in the overlay attributes instead of overlaycall and overlaydata
respectively.
@oferShinaar
Copy link
Collaborator

Same comment as in #32 (review)
We need an explanation before merging.
NOTE: The toolchain link on CHIPS will not be changed until we have something build

@oferShinaar oferShinaar requested a review from nidalf November 29, 2021 13:15
Copy link
Collaborator

@oferShinaar oferShinaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need testing ref before merge

@edward-jones
Copy link
Contributor Author

Okay here are steps used for testing:

Updating LLVM tool chain

The LLVM tool chain needs to be updated to use the latest overlay patch. This should be in the comrv branch at https://github.com/westerndigitalcorporation/llvm-project/tree/comrv but that branch needs to be updated based on the patches currently up for review:

Update to use -moverlay instead of -fcomrv in the build of the demos

The branch in this pull request should be applied. This updates the build system in the demos to use -moverlay instead of -fcomrv

Use renamed attributes in this pull request

The branch in this pull request should also be applied to get the RT engine to use __attribute__((overlay_call)) and __attribute__((overlay_data)) instead of the old names.

Configure and build the cti demo

Run through the steps to build the 'cti' demo

$ cd riscv-fw-infrastructure/WD-Firmware/demo/build
$ ./config.sh

Select the cti demo, build with scons targetting eh1

$ scons -c target=eh1 && scons target=eh1

Run on the board through openocd - I'm not sure what the generic way of doing this is.

@oferShinaar
Copy link
Collaborator

This PR was integrated into the pre-release repo (different domain).
Once we have fully built toolchain, we will also release FW that encapsulate PR #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants