benchmarks: Various fixes for compiling with Clang#502
Open
widlarizer wants to merge 3 commits intoriscv-software-src:masterfrom
Open
benchmarks: Various fixes for compiling with Clang#502widlarizer wants to merge 3 commits intoriscv-software-src:masterfrom
widlarizer wants to merge 3 commits intoriscv-software-src:masterfrom
Conversation
It's unnecessary and non-portable; Clang doesn't even implement that part of GNU C. (cherry picked from commit 50d75cb)
Clang only supports register variables when declared at global scope (and only for non-allocatable registers, which is fine for tp), so move thread_pointer. This does not make thread_pointer visible outside the translation unit, it merely acts as a C alias for tp, so the semantics remain unchanged. (cherry picked from commit 20378c0)
aswaterman
reviewed
Sep 20, 2023
Collaborator
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
Did you verify this all still works with GCC?
I think the replacement of RISCV_GCC with RISCV_CC is a little too ideological for a PR whose purpose is to fix things, but I guess it's OK.
Author
|
I can't address this immediately but I hope to play with riscv-tests some more next week and let you know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#225 except -T behaves just fine with clang so we don't have to mess with that. Also renamed references to GCC to CC