Skip to content

Merge new command "list csrs" CLI #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Merge new command "list csrs" CLI #909

wants to merge 4 commits into from

Conversation

adingank-qualcomm
Copy link
Collaborator

Added test_list_csrs with an assertion for equality of the number of CSRs reported with the number of yaml files under csr directory.

@adingank-qualcomm
test(csr): list csrs
0c77696 
Add "list csrs" command to CLI.
@adingank-qualcomm
test(csr): check number of csrs listed
b12b3a1 
Check that all CSRs for the default Unconfigured are listed.
@adingank-qualcomm
test(csr): compare number of listed CSRs with count of yaml files
8a1e39f 
The expected number of CSRs reported is the number of yaml files under spec/std/isa/csr/.
@adingank-qualcomm
Merge branch 'main' into ajit/cli/test_csr
d0e69a4
@adingank-qualcomm
Copy link
Collaborator Author

... and the new test failed with expected result of 0! :-)
I suspect that the smoke regression not run from the root and hence spec/std/isa/csr is not found (unlike my local runs).
Have to learn the right process for testing (even for this baby step PR)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhower-qc dhower-qc Awaiting requested review from dhower-qc dhower-qc is a code owner

@ThinkOpenly ThinkOpenly Awaiting requested review from ThinkOpenly ThinkOpenly is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adingank-qualcomm