Better description of how etrigger matches.#1085
Better description of how etrigger matches.#1085pdonahue-ventana wants to merge 2 commits intoriscv:mainfrom
Conversation
xml/hwbp_registers.xml
Outdated
| causes are configured by writing the corresponding bit in {csr-tdata2}. | ||
| (E.g. to trap on an illegal instruction, the debugger sets bit 2 in | ||
| {csr-tdata2}.) | ||
| This trigger can match when a trap is taken due to an exception. |
There was a problem hiding this comment.
This feels like a very wish-washy statement.
How about:
This trigger matches when an exception is taken and the bit corresponding to the exception is set in tdata2.
Probably requires rewriting the paragraph below for it all to make sense.
There was a problem hiding this comment.
This feels like a very wish-washy statement.
I agree. I didn't like the phrasing but I was trying to match the existing itrigger description which was updated last year. I was trying to limit the scope of this change but maybe we should update itrigger, too.
| The trigger may be configured to match on up to XLEN of the Exception | ||
| Codes defined in `mcause` (described in the Privileged Spec, with | ||
| Interrupt=0). Those causes are configured by writing the corresponding | ||
| bit in {csr-tdata2}. (e.g. to have etrigger match on an illegal | ||
| instruction trap, the debugger sets bit 2 in {csr-tdata2}.) |
There was a problem hiding this comment.
This still doesn't say that the trigger matches when an exception is taken, which is what your change description says you wanted to accomplish.
|
Now that this is ratified, I think that any changes need to be reviewed by Ved. The two of us can continue to polish this. Then I think that we can gather up any pending clarifications over some period of time and send them all in a batch to him. |
2 participants
The previous language talked about "When the trigger matches" but it never described matching. It said that it could fire on mcause codes but did that mean a CSR write instruction with a particular mcause value could make it fire? I think that this is better.
Fixes #1084.