Add initial pre-commit and fix up and issues #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbroch-rivosinc
force-pushed
the
dev/kbroch/pre-commit-initial
branch
from
848a792
to
58aa1a4
Compare
kbroch-rivosinc
force-pushed
the
dev/kbroch/pre-commit-initial
branch
from
58aa1a4
to
af84653
Compare
kbroch-rivosinc
force-pushed
the
dev/kbroch/pre-commit-initial
branch
from
af84653
to
4db01b0
Compare
|
Sorry about the forced pushing above, I didn't change anything but had forgot to do the |
|
No worries.
…On Wed, Apr 24, 2024 at 2:12 PM Kevin Broch ***@***.***> wrote:
Sorry about the forced pushing above, I didn't change anything but had
forgot to do the git commit -S and at first I thought I only needed git
commit -s which is why there's multiple forced push. I'll try not to make
a mess of things next time 😉
—
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN6ZA4LGFJA55PWP6BLFLY67YYNAVCNFSM6AAAAABGXLUOXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGU2DQMRSGY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
relates to #8 and #9 Signed-off-by: Kevin Broch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #9