Add configuration option for reserved behavior pmpcfg with r=0, w=1
#1422
+43
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timmmm
requested changes
Dec 17, 2025
Collaborator
Timmmm
left a comment
Timmmm
left a comment
There was a problem hiding this comment.
Nice! LGTM, just a few minor naming tweaks.
Test Results2 115 tests 2 115 ✅ 17m 53s ⏱️ Results for commit 00aee87. ♻️ This comment has been updated with latest results. |
Author
|
last commit,
|
pmundkur
requested changes
Dec 18, 2025
Collaborator
pmundkur
left a comment
pmundkur
left a comment
There was a problem hiding this comment.
Perhaps rebase this while you're at it?
model/pmp/pmp_regs.sail
Outdated
| // 1. exit the simulation with a fatal error | ||
| // 2. R, W and X are all set to 0. | ||
| let cfg = if cfg[W] == 0b1 & cfg[R] == 0b0 then ( | ||
| match (config base.reserved_behavior.pmpcfg_write_only : PmpWriteOnlyReservedBehavior) { |
Collaborator
There was a problem hiding this comment.
Same suggestion as #1403: hoist this into a let in core/platform_config.sail.
challenger1024
force-pushed
the
pmpcfg-r0-w1
branch
from
1297d58 to
79e4f83
Compare
Author
|
last commit, Move PmpWriteOnlyReservedBehavior from types.sail to platform_config.sail, and add the variable pmp_write_only_reserved_behavior in platform_config.sail. |
…sail, and add the variable pmp_write_only_reserved_behavior in platform_config.sail.
pmundkur
force-pushed
the
pmpcfg-r0-w1
branch
from
79e4f83 to
00aee87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration option for reserved behavior pmpcfg with R=0 and W=1.
It allows two options: a fatal error that stops the simulation, or setting it to R=0, W=0, X=0 as the default choice.
See #775