-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): lossy "purify" column default value #19993
Open
BugenZhao
wants to merge
6
commits into
main
Choose a base branch
from
bz/purify-sql-part-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2025
8 tasks
8 tasks
BugenZhao
force-pushed
the
bz/purify-sql-part-2
branch
from
January 2, 2025 09:40
5f3ec2c
to
72ea3cf
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-3
branch
from
January 2, 2025 09:41
5d7a9dc
to
9674e8d
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-2
branch
from
January 2, 2025 09:45
72ea3cf
to
5f8b6ef
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-3
branch
from
January 2, 2025 09:45
9674e8d
to
4e2ba8c
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-2
branch
from
January 2, 2025 09:52
5f8b6ef
to
274a032
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-3
branch
from
January 2, 2025 09:52
4e2ba8c
to
f31c80f
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-2
branch
from
January 3, 2025 03:30
274a032
to
ec38b32
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-3
branch
from
January 3, 2025 03:30
f31c80f
to
66cb893
Compare
BugenZhao
commented
Jan 3, 2025
Comment on lines
-69
to
-70
|
||
return Ok(base); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously we short-circuited the procedure once we find all columns are present. Now we should always go through the step for filling the default value.
BugenZhao
force-pushed
the
bz/purify-sql-part-2
branch
from
January 6, 2025 05:53
ec38b32
to
6ec6062
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-3
branch
from
January 6, 2025 05:53
34145ee
to
b958c45
Compare
BugenZhao
force-pushed
the
bz/purify-sql-part-3
branch
from
January 7, 2025 06:08
b958c45
to
fc48f02
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
…raint Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/purify-sql-part-3
branch
from
January 13, 2025 08:04
fc48f02
to
1126076
Compare
BugenZhao
changed the title
feat(frontend): "purify" column default value
feat(frontend): lossy "purify" column default value
Jan 13, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In #19949 we mentioned that
which is the very missing piece of definition purification.
In this PR, we allow converting persisted
DefaultColumnDesc
back toast::ColumnOption::DefaultValue
losslessly, by simply storing the encoded value temporarily into the AST.Apparently this is somehow hacky, as unparsing the AST back to SQL will still lose such information. However, this can still be beneficial for...
get_new_table_definition_for_cdc_table
ALTER TABLE
will refresh previous snapshot values for absent cells #17121 once we adopt the purified definition for replacing job...as long as we believe that AST is the best intermediate representation for schema change.
Checklist
Documentation
Release note