Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): support excluded bound in storage table #20138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Jan 13, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#17018 supports excluded key range in storage iterator but storage table still converts excluded bound to included before creating the iterator. This PR adopts excluded range bound in storage table and resolve #16219.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@hzxa21 hzxa21 requested review from chenzl25 and Li0k January 13, 2025 11:51
@github-actions github-actions bot added the type/fix Bug fix label Jan 13, 2025
@chenzl25
Copy link
Contributor

It seems the e2e test failed.
https://buildkite.com/risingwavelabs/pull-request/builds/66117#01945f8d-0c15-4b80-9efc-557cd3352c12

failed to run `e2e_test/visibility_mode/barrier.slt`
--
  |  
  | Caused by:
  | query result mismatch:
  | [SQL] SELECT * FROM orders_count_by_user_1 WHERE user_id < 43;
  | [Diff] (-expected\|+actual)
  | 42 1111 1
  | 42 2222 2
  | -   42 3333 1
  | +   42 3333 1
  | +   43 1111 1
  | +   43 2222 1
  | at e2e_test/visibility_mode/../batch/./basic/range_scan.slt.part:65
  | at e2e_test/visibility_mode/../batch/distribution_mode.slt:7
  | at e2e_test/visibility_mode/barrier.slt:4


@hzxa21
Copy link
Collaborator Author

hzxa21 commented Jan 13, 2025

It seems the e2e test failed.
https://buildkite.com/risingwavelabs/pull-request/builds/66117#01945f8d-0c15-4b80-9efc-557cd3352c12

failed to run `e2e_test/visibility_mode/barrier.slt`
--
  |  
  | Caused by:
  | query result mismatch:
  | [SQL] SELECT * FROM orders_count_by_user_1 WHERE user_id < 43;
  | [Diff] (-expected\|+actual)
  | 42 1111 1
  | 42 2222 2
  | -   42 3333 1
  | +   42 3333 1
  | +   43 1111 1
  | +   43 2222 1
  | at e2e_test/visibility_mode/../batch/./basic/range_scan.slt.part:65
  | at e2e_test/visibility_mode/../batch/distribution_mode.slt:7
  | at e2e_test/visibility_mode/barrier.slt:4


will check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: select a mv panic
3 participants