-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add resource_group
to rw_streaming_jobs
#20207
Conversation
758c7d3
to
e216931
Compare
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
…dd `specific_resource_group` field.
e216931
to
c74a026
Compare
…ssert `"NULL"` in `test_resource_group`.
Please also confirm if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… related calls Signed-off-by: Shanicky Chen <[email protected]>
LGTM on the design. cc. @CAJan93 to take a look. |
…oto and struct Signed-off-by: Shanicky Chen <[email protected]>
80ce249
to
35ea07f
Compare
specific_resource_group
to rw_streaming_jobs
resource_group
to rw_streaming_jobs
Hi, there. 📝 Telemetry Reminder:
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR creates a new
rw_streaming_jobs
system catalog based on the existingrw_table_fragments
, adding thename
field andresource_group
field to display resource groups. By default, this field should be inherited from database. Additionally, this PR includes mock tests to verify the correctness of theALTER RESET RESOURCE_GROUP
command.As many test scripts depend on
rw_table_fragments
, it will be deprecated in a future PR and replaced withrw_streaming_jobs
.Checklist