Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iceberg): add 'glue.id' to iceberg sink config #20330

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(iceberg): add 'glue.id' to iceberg sink config #20330

wants to merge 4 commits into from
+26 −0

Conversation

jayakasadev
Copy link

@jayakasadev jayakasadev commented Jan 27, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • add glue.id to src/connector/src/connector_common/iceberg/mod.rs and src/connector/src/connector_common/connection.rs
    • allow users to optionally specify glue catalog id

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@jayakasadev jayakasadev force-pushed the add_glue_id_to_iceberg_sink branch 2 times, most recently from 0c3fa31 to 3b049fb Compare January 27, 2025 18:59
@yuhao-su yuhao-su requested review from chenzl25 and xxhZs January 27, 2025 19:04
@jayakasadev jayakasadev force-pushed the add_glue_id_to_iceberg_sink branch from 3b049fb to 078f09e Compare January 27, 2025 19:22
xxchan
xxchan approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (ref https://iceberg.apache.org/docs/latest/aws/#glue-catalog-id)

BTW did you test that it works in your environment?

@jayakasadev
Copy link
Author

i haven't setup the pipeline to deploy the image using our infra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

@chenzl25 chenzl25 Awaiting requested review from chenzl25

@xxhZs xxhZs Awaiting requested review from xxhZs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayakasadev @xxchan