Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add configurable sync call timeout for sources #20828

Merged
merged 6 commits into from
Mar 12, 2025
Merged

feat: Add configurable sync call timeout for sources #20828

merged 6 commits into from
Mar 12, 2025

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Mar 11, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title, allow configurable sync call timeout, not bounded by 10s

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@tabVersion tabVersion requested review from shanicky and lmatz March 11, 2025 07:14
shanicky
shanicky approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tabVersion tabVersion enabled auto-merge March 11, 2025 07:52
@lmatz lmatz mentioned this pull request Mar 12, 2025
Open
@tabVersion tabVersion added this pull request to the merge queue Mar 12, 2025
Merged via the queue into main with commit 6812577 Mar 12, 2025
45 of 46 checks passed
@tabVersion tabVersion deleted the tab/sync-call-time-out branch March 12, 2025 10:44
@github-actions github-actions bot mentioned this pull request Mar 27, 2025
Closed
This was referenced Mar 28, 2025
Open
Open
Open
lmatz pushed a commit that referenced this pull request Mar 28, 2025
@tabVersion @lmatz
feat: Add configurable sync call timeout for sources (#20828)
cd4440e 
Co-authored-by: tab <[email protected]>
lmatz pushed a commit that referenced this pull request Mar 28, 2025
@tabVersion @lmatz
feat: Add configurable sync call timeout for sources (#20828)
23f73d0 
Co-authored-by: tab <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Apr 2, 2025
@lmatz @tabVersion
feat: Add configurable sync call timeout for sources (#20828) (#21154)
c25bad4 
Co-authored-by: Bohan Zhang <[email protected]>
Co-authored-by: tab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanicky shanicky shanicky approved these changes

@lmatz lmatz lmatz approved these changes

Assignees
No one assigned
Labels
ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends need-cherry-pick-release-2.1 need-cherry-pick-release-2.2 need-cherry-pick-release-2.3 need-cherry-pick-since-release-2.1 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tabVersion @shanicky @lmatz