Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(foyer): fix foyer split condition calculation error #21145

Merged
merged 5 commits into from
Mar 28, 2025
Merged

fix(foyer): fix foyer split condition calculation error #21145

merged 5 commits into from
Mar 28, 2025

Conversation

MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Mar 27, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

Highest Release Version: 2.3

What's changed and what's your intention?

foyer side changes:

  • Fix blob/region split condition calculation error.
  • Add ut for the corner case.
  • Refine splitter code.
  • Fix direct fs error log.

foyer-rs/foyer#912
foyer-rs/foyer#905
#21116
close #21157

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@MrCroxx MrCroxx requested a review from a team as a code owner March 27, 2025 16:46
@MrCroxx MrCroxx requested a review from BugenZhao March 27, 2025 16:46
MrCroxx added 2 commits March 28, 2025 02:26
@MrCroxx
chore: add more lgos
c68a0d1 
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx
chore: more logs
f35cbca 
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx changed the title chore: add some foyer debug log fix(foyer): fix foyer split condition calculation error Mar 28, 2025
@github-actions github-actions bot added the type/fix Bug fix label Mar 28, 2025
@MrCroxx MrCroxx requested a review from Li0k March 28, 2025 07:15
@MrCroxx
Copy link
Contributor Author

MrCroxx commented Mar 28, 2025

longevity test:

https://buildkite.com/risingwave-test/longevity-test/builds/2393#0195dba4-51db-4445-bdae-e07132fe82fb

@MrCroxx MrCroxx requested review from hzxa21 and wenym1 and removed request for BugenZhao March 28, 2025 09:05
@MrCroxx MrCroxx added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit 602d2f7 Mar 28, 2025
28 of 29 checks passed
@MrCroxx MrCroxx deleted the xx/foyerdbg branch March 28, 2025 10:32
MrCroxx added a commit that referenced this pull request Mar 29, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145
b467720 
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx mentioned this pull request Mar 29, 2025
Merged
8 tasks
MrCroxx added a commit that referenced this pull request Mar 29, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145
b03d81e 
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx mentioned this pull request Mar 29, 2025
Merged
8 tasks
MrCroxx added a commit that referenced this pull request Mar 29, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145
524521f 
Signed-off-by: MrCroxx <[email protected]>
MrCroxx added a commit that referenced this pull request Mar 29, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145
70b76fd 
Signed-off-by: MrCroxx <[email protected]>
MrCroxx added a commit that referenced this pull request Mar 29, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145
e11757c 
Signed-off-by: MrCroxx <[email protected]>
@MrCroxx MrCroxx mentioned this pull request Mar 29, 2025
Merged
8 tasks
github-merge-queue bot pushed a commit that referenced this pull request Mar 31, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145 (#21171)
f78271e 
Signed-off-by: MrCroxx <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Mar 31, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145 (#21170)
4b88821 
Signed-off-by: MrCroxx <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Mar 31, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145 (#21173)
2d52da7 
Signed-off-by: MrCroxx <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Mar 31, 2025
@MrCroxx
fix: fix foyer panics, cherry pick #21145 (#21172)
5606617 
Signed-off-by: MrCroxx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxa21 hzxa21 hzxa21 approved these changes

@Li0k Li0k Awaiting requested review from Li0k

@wenym1 wenym1 Awaiting requested review from wenym1

Assignees
No one assigned
Labels
type/chore type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: longevity test failed 20250327
3 participants
@MrCroxx @hzxa21 @Li0k