Skip to content

Conversation

@wenym1
Copy link
Contributor

@wenym1 wenym1 commented Apr 1, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

Highest Release Version: 2.3

What's changed and what's your intention?

Add madsim test for coordinated sink. Existing tests is fully reused.

For coordinated sink, the sink writers write data to a staging store with a handle id, and include the handle id as the sink metadata. When coordinator commits, it resolves the handle ids from sink metadata, retrieves staging data from staging store, and then add the staging data to the global store.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/feature Type: New feature. label Apr 1, 2025
@wenym1 wenym1 force-pushed the yiming/skip-item-align-coordinated-sink-initial-epoch branch from 81ce43f to 1f2f02e Compare April 1, 2025 13:15
@wenym1 wenym1 force-pushed the yiming/coordinated-sink-madsim-test branch from de94139 to d915f50 Compare April 1, 2025 13:16
Copy link
Contributor Author

wenym1 commented Apr 1, 2025

@wenym1 wenym1 force-pushed the yiming/skip-item-align-coordinated-sink-initial-epoch branch from 1f2f02e to 2474f13 Compare April 3, 2025 16:58
@wenym1 wenym1 force-pushed the yiming/coordinated-sink-madsim-test branch from 5a2b54b to 17514ec Compare April 3, 2025 16:58
@wenym1 wenym1 requested review from hzxa21 and wcy-fdu April 7, 2025 06:15
@wenym1 wenym1 force-pushed the yiming/skip-item-align-coordinated-sink-initial-epoch branch from 2474f13 to 8cb7900 Compare April 7, 2025 09:48
@wenym1 wenym1 force-pushed the yiming/coordinated-sink-madsim-test branch from 17514ec to 3caf9a2 Compare April 7, 2025 09:49
Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the efforts!
Sorry that I did not review in order. I reviewed this part first and will continue to review the previous two PRs later.

@wenym1 wenym1 force-pushed the yiming/skip-item-align-coordinated-sink-initial-epoch branch from 8cb7900 to 780547a Compare April 9, 2025 11:52
@wenym1 wenym1 force-pushed the yiming/coordinated-sink-madsim-test branch 2 times, most recently from 95ad590 to 7f1e978 Compare April 10, 2025 06:17
@wenym1 wenym1 force-pushed the yiming/skip-item-align-coordinated-sink-initial-epoch branch from 70341bd to 505bb59 Compare April 11, 2025 13:30
@wenym1 wenym1 force-pushed the yiming/coordinated-sink-madsim-test branch from 7f1e978 to 5d2b9ef Compare April 11, 2025 13:30
Base automatically changed from yiming/skip-item-align-coordinated-sink-initial-epoch to main April 14, 2025 10:37
@wenym1 wenym1 added this pull request to the merge queue Apr 15, 2025
Merged via the queue into main with commit 419c220 Apr 15, 2025
29 of 30 checks passed
@wenym1 wenym1 deleted the yiming/coordinated-sink-madsim-test branch April 15, 2025 04:40
@BugenZhao
Copy link
Member

It seems that integration test (madsim) - sink starts to fail stably (maybe OOM) since this PR. Would you help to investigate?

https://buildkite.com/risingwavelabs/main-cron/builds/4871#_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants