-
Notifications
You must be signed in to change notification settings - Fork 724
feat(sink): add madsim tests for coordinated sink #21214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81ce43f to
1f2f02e
Compare
de94139 to
d915f50
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1f2f02e to
2474f13
Compare
5a2b54b to
17514ec
Compare
2474f13 to
8cb7900
Compare
17514ec to
3caf9a2
Compare
wcy-fdu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the efforts!
Sorry that I did not review in order. I reviewed this part first and will continue to review the previous two PRs later.
8cb7900 to
780547a
Compare
95ad590 to
7f1e978
Compare
70341bd to
505bb59
Compare
7f1e978 to
5d2b9ef
Compare
|
It seems that https://buildkite.com/risingwavelabs/main-cron/builds/4871#_ |

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
Highest Release Version: 2.3
What's changed and what's your intention?
Add madsim test for coordinated sink. Existing tests is fully reused.
For coordinated sink, the sink writers write data to a staging store with a handle id, and include the handle id as the sink metadata. When coordinator commits, it resolves the handle ids from sink metadata, retrieves staging data from staging store, and then add the staging data to the global store.
Checklist
Documentation
Release note