feat(ci): support workflow for docker image building #21626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
force-pushed
the
kwannoel/workflow-update-branch
branch
from
1e14fd4 to
e462af7
Compare
kwannoel
changed the title
github-actions
bot
added
type/feature
kwannoel
force-pushed
the
kwannoel/workflow-update-branch
branch
from
ff7aff5 to
fb373ba
Compare
BugenZhao
reviewed
May 5, 2025
| echo "LABEL=$LABEL" >> $GITHUB_ENV | ||
|
|
||
| # Build the image tag | ||
| IMAGE_TAG="v$VERSION--$LABEL--$COMMIT_SHA--$NO_SLASH_BRANCH_NAME" |
There was a problem hiding this comment.
Is it expected to have 2 dash here?
There was a problem hiding this comment.
Yes, because branch name can also include dash. I want to clearly delimit each segment. So the tag name is machine readable, and further validation can be done.
|
Any further comments? |
BugenZhao
approved these changes
May 7, 2025
|
✅ Cherry-pick PRs (or issues if encountered conflicts) have been created successfully to all target branches. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2025
Co-authored-by: Noel Kwan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2025
Co-authored-by: Noel Kwan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2025
Co-authored-by: Noel Kwan <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 8, 2025
Co-authored-by: Noel Kwan <[email protected]>
xxchan
reviewed
May 8, 2025
kwannoel
added a commit
that referenced
this pull request
May 30, 2025
Co-authored-by: Noel Kwan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #21601.
This PR reduces margin for human error due to manual tagging of images. It also makes tagging entirely optional. We can automatically generate semantically correct tagging after this PR:
We use
--, to clearly delimit different sections. Since hyphens-can be used within each segment as well. It will only be a problem if developer uses-as a prefix or suffix. I think that's unlikely.Test workflow dispatch via cli (actual use will just be via github UI for workflows, see screenshot below):
example run
After this PR is merged, we can have a similar UX to this (we won't actual fill in a version, just an arbitrary tag, ignore that part):
This gives us a "form-filling experience", as requested by @BugenZhao. It's inspired by the work by @arkbriar for image building in our other repositories.
Subsequently, I will add docs for how to use this workflow in our internal and developer docs.
Checklist
Documentation
Release note