Skip to content

fix(connector): add timeout and retry for kinesis client (#21616) #22118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix(connector): add timeout and retry for kinesis client (#21616) #22118

wants to merge 3 commits into from

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Jun 5, 2025 •
edited
Loading

(cherry picked from commit 14d4c71)

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #22115

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@zwang28 zwang28 requested review from tabVersion and cyliu0 June 5, 2025 05:49
@zwang28 zwang28 enabled auto-merge June 5, 2025 05:49
@github-actions github-actions bot added type/fix Type: Bug fix. Only for pull requests. ci/main-cron/run-all labels Jun 5, 2025
@zwang28 zwang28 added the cherry-pick The PR is to cherry-pick new commits to an old release branch. label Jun 5, 2025
@zwang28 zwang28 requested a review from lmatz June 5, 2025 05:51
@zwang28 zwang28 disabled auto-merge June 6, 2025 01:24
@zwang28 zwang28 enabled auto-merge June 6, 2025 01:24
@zwang28
Copy link
Contributor Author

zwang28 commented Jun 9, 2025 

thread '<unnamed>' panicked at src/meta/src/barrier/rpc.rs:338:46:
worker should exist for inflight actor

Recovery test is failing due to this bug. @wenym1

@zwang28 zwang28 closed this Jun 10, 2025
auto-merge was automatically disabled June 10, 2025 04:09

Pull request was closed

@tabVersion tabVersion mentioned this pull request Jun 10, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxa21 hzxa21 hzxa21 approved these changes

@lmatz lmatz lmatz approved these changes

@tabVersion tabVersion tabVersion approved these changes

@cyliu0 cyliu0 Awaiting requested review from cyliu0

Assignees
No one assigned
Labels
cherry-pick The PR is to cherry-pick new commits to an old release branch. ci/main-cron/run-all ci/run-e2e-single-node-tests ci/run-e2e-test-other-backends type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zwang28 @hzxa21 @lmatz @tabVersion @wenym1