Skip to content

chore: update iceberg-compaction dep #22294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2025
Merged

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Jun 19, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@Li0k Li0k requested review from hzxa21, chenzl25 and xxhZs June 19, 2025 15:05
@Li0k Li0k requested a review from a team as a code owner June 19, 2025 15:05
@Li0k Li0k enabled auto-merge June 20, 2025 02:17
@@ -6879,10 +6840,23 @@ dependencies = [
"uuid",
]

[[package]]
name = "iceberg-catalog-memory"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency does not exist before. Is it expected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, its introduced by iceberg-compaction. But maybe I can remove it through some feature flags or by reorging the crate. Let's update it in the next release.

@hzxa21 hzxa21 changed the title chore: update iceberg-compact dep chore: update iceberg-compaction dep Jun 20, 2025
@Li0k Li0k added this pull request to the merge queue Jun 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2025
@Li0k Li0k added this pull request to the merge queue Jun 21, 2025
Merged via the queue into main with commit 57924b5 Jun 21, 2025
33 of 34 checks passed
@Li0k Li0k deleted the li0k/update-iceberg-compact-dep branch June 21, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants