Skip to content

feat(frontend): disallow backfill order with cross-db snapshot backfill #22300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jun 20, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Added a check to prevent using backfill order control with cross-database snapshot backfill operations. This change:

  1. Adds a new has_cross_db_snapshot_backfill flag to the BuildFragmentGraphState struct to track when cross-database snapshot backfill is used
  2. Sets this flag when a cross-database snapshot backfill stream scan is encountered
  3. Adds validation logic to return a clear error message when users attempt to combine backfill order control with cross-database snapshot backfill

This prevents users from attempting unsupported combinations of features and provides a clear error message explaining the limitation.

I've updated the release note of fixed backfill order control to mention this: #20967.

Checklist

  • I have written necessary rustdoc comments.

@kwannoel kwannoel marked this pull request as ready for review June 20, 2025 03:17
@github-actions github-actions bot added the type/feature Type: New feature. label Jun 20, 2025
@kwannoel kwannoel requested review from chenzl25 and wenym1 June 20, 2025 03:18
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May create an issue to track the follow-up.

@kwannoel
Copy link
Contributor Author

LGTM. May create an issue to track the follow-up.

Tracked in #20861

@kwannoel kwannoel force-pushed the kwannoel/backfill-order-snapshot-backfill branch from 7bb99fc to 567a963 Compare June 20, 2025 05:42
@kwannoel kwannoel force-pushed the kwannoel/backfill-order-cross-snapshot branch from c718357 to d161e37 Compare June 20, 2025 05:42
Base automatically changed from kwannoel/backfill-order-snapshot-backfill to main June 20, 2025 07:00
@kwannoel kwannoel force-pushed the kwannoel/backfill-order-cross-snapshot branch from d161e37 to 7ae25ea Compare June 20, 2025 07:07
@kwannoel kwannoel enabled auto-merge June 20, 2025 07:20
@kwannoel kwannoel added this pull request to the merge queue Jun 20, 2025
auto-merge was automatically disabled June 20, 2025 07:51

Pull Request is not mergeable

Merged via the queue into main with commit b1cbf2e Jun 20, 2025
33 of 34 checks passed
@kwannoel kwannoel deleted the kwannoel/backfill-order-cross-snapshot branch June 20, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants