Inject code to last candidate #2705
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than injecting into the first match of "</body>" , it will inject into the last found occurrence of it. This will avoid overwriting code following the tag. Also works for the head regex.
Author
|
adjusting the head regex may not fix the issue, but the body fix will, and it is the most commonly used / reported issue |
|
I'm facing an issue due to this. Is there any plan to merge this fix? <!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
<script>
"</body>"
</script>
</body>
</html>Results in: |
Author
Highly doubt it. The extension hasn't been updated for over a year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than injecting into the first match of "
</body>" , it will inject into the last found occurrence of it. This will avoid overwriting code following the tag. Also works for the head regex.PR Type
What kind of change does this PR introduce?
Fix injection candidate regex
[x] Bugfix [ ] Feature [ ] Refactoring (no functional changes, no api changes) [ ] Documentation content changes [ ] Other: <!-- Please describe: -->What is the current behavior?
matches the first occurrence of a tag and overrides code
Issue Number: N/A (there were multiple issues referring to this issue)
What is the new behavior?
matches the last occurrence of a tag
Does this PR introduce a breaking change?
Other information