fix: multiple logging improvements and various other fixes

[dreulavelle]

Pull Request Check List

Resolves: #issue-number-here

• Added tests for changed code.
• Updated documentation for changed code.

Description:

Summary by CodeRabbit

• New Features

  • Added a method to retrieve season title details, enhancing media information display.

• Bug Fixes

  • Updated media state assessment to more accurately reflect content availability.
  • Enhanced error handling in download and torrent processes, providing clearer, actionable feedback.
  • Refined scraping checks to prevent redundant processing and improved duplicate handling in media retrieval.

• Refactor

  • Optimized the symlink creation workflow for more reliable media linking.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This PR updates the media state logic in the MediaItem, Show, and Season classes by switching from strict (all()) to lenient (any()) conditions. It adds a new method for title retrieval in the Season class and refines error handling in the RealDebrid downloader. Additional modifications include adjustments in scraper torrent processing, enhanced control flow in the symlink creation process, and improved query filtering with detailed duplicate error logging in secure item retrieval.

Changes

File(s)	Change Summary
src/program/media/item.py	Updated _determine_state in MediaItem, Show, and Season (using any() instead of all()); added new get_top_title method in Season with session refresh.
src/program/services/downloaders/realdebrid.py	Enhanced error handling in get_instant_availability and add_torrent with conditional checks on exception arguments and detailed debug logging.
src/program/services/indexers/trakt.py	Removed extraneous empty lines at the end of _add_seasons_to_show.
src/program/services/scrapers/__init__.py src/program/services/scrapers/shared.py	Centralized active stream check in can_we_scrape (removing it from should_submit) and refined torrent selection logic in _parse_results with additional conditions and improved logging.
src/program/symlink.py	Introduced symlink result tracking in run: logs success if _symlink returns true; if false, logs the event, then calls blacklist_active_stream() and reset(). Also clarified the error message regarding the "rclone path."
src/routers/secure/items.py	Modified item query filtering to use MediaItem.id with type restrictions and improved error handling with duplicate detection and logging in the event of multiple matching rows.

Sequence Diagram(s)

Loading

sequenceDiagram
    participant S as Symlinker
    participant I as Media Item
    participant L as Logger

    loop For each item
        S->>I: Attempt _symlink(item)
        alt Symlink Successful (True)
            L->>S: Log "Symlink created"
        else Symlink Failed (False)
            L->>S: Log "No symlink created"
            S->>I: Call blacklist_active_stream()
            S->>I: Call reset()
        end
    end

Possibly related PRs

• Add pause feature to backend #886: Updates on MediaItem pause functionality that similarly adjust state management logic.
• fix: re-check ongoing/unreleased items #880: Involves modifications in the MediaItem class that relate closely to the _determine_state updates in this PR.
• fix: minor tweaks and validation handling #1009: Addresses state handling for paused/failed states in media items, aligning with the logic changes seen here.

Suggested reviewers

• Gaisberg

Poem

I'm a happy rabbit, hopping through code,
Where state checks now merrily lighten the load.
With symlinks and torrents dancing in line,
Each debug log sings, oh so divine.
Carrot crunches and code so bright—
Hopping to a future of bug-free delight!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3278d64 and 4641088.

⛔ Files ignored due to path filters (1)

• poetry.lock is excluded by !**/*.lock

📒 Files selected for processing (7)

• src/program/media/item.py (4 hunks)
• src/program/services/downloaders/realdebrid.py (3 hunks)
• src/program/services/indexers/trakt.py (0 hunks)
• src/program/services/scrapers/__init__.py (1 hunks)
• src/program/services/scrapers/shared.py (3 hunks)
• src/program/symlink.py (2 hunks)
• src/routers/secure/items.py (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.