-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Hub Support #19
Conversation
Alright, this is ready for review. |
``` | ||
|
||
> [!WARNING] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Arent settings copied from default settings.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but you can't bind mount a file that isn't there. And if you bind mount to an empty file, it creates issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The best way arround this is to bind to a directory.. so if we toss settings.json into a settings/settings.json
and we binded to settings
dir. Then it would work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah move settings.json to data folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data, logs, and settings.json
Should be in a folder together I think? then we can just bind that 1 directory:
- ./config:/config
Or something to that effect..
There is one issue with this PR. The backend api isn't exposed. So only the front end (since its inside the container) can see the api for backend. If we want to see the backend api as well, I'll need to expose it in the Dockerfile and then add the port to the compose. Is this something we care about? @Gaisberg @AyushSehrawat |
End user doesnt need the backend api exposed |
Recreated in another branch. Deleting/Ending this PR. |
Initial Commit
Add completed Dockerfile
Add Docker Hub integration