Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting validation for classes etc. #5

Closed
wants to merge 2 commits into from
Closed

Conversation

Gaisberg
Copy link
Collaborator

@Gaisberg Gaisberg commented Dec 9, 2023

  • Rename settings, dont need type prefix
  • Verify in modules themselves
  • Dont start without all necessary modules

Copy link
Member

@AyushSehrawat AyushSehrawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dreulavelle
Copy link
Member

  • Dont start without all necessary modules

RD validation should cause the app to stop I think? Furthermore, since I assume we'll be adding Jellyfin/Emby later.. we could require at least 1 "library" app to be setup in the settings and validated so at least we have 1 library app.

I don't think this will be required for "content" since if Plex/Emby/Jellyfin are validated, then we can use those watchlists to get content by default.. then users aren't required to use Overseerr or Mdblist.. or any other ones we add.

Need to determine where we get metadata so its not inclusive on requiring an API key.

Thoughts? @Gaisberg @AyushSehrawat

Copy link
Member

@dreulavelle dreulavelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read feedback/comments.

self.auth_headers = {"Authorization": f'Bearer {self.settings["api_key"]}'}
self._torrents = {}
# Realdebrid class library is a necessity
while True:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't agree with the continuous validation of RD. Since the app is meant for RD, would it be better to just exit the app if the first validation fails for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreulavelle dreulavelle closed this Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants