-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting validation for classes etc. #5
Conversation
Gaisberg
commented
Dec 9, 2023
•
edited
Loading
edited
- Rename settings, dont need type prefix
- Verify in modules themselves
- Dont start without all necessary modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
RD validation should cause the app to stop I think? Furthermore, since I assume we'll be adding Jellyfin/Emby later.. we could require at least 1 "library" app to be setup in the settings and validated so at least we have 1 library app. I don't think this will be required for "content" since if Plex/Emby/Jellyfin are validated, then we can use those watchlists to get content by default.. then users aren't required to use Overseerr or Mdblist.. or any other ones we add. Need to determine where we get metadata so its not inclusive on requiring an API key. Thoughts? @Gaisberg @AyushSehrawat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read feedback/comments.
self.auth_headers = {"Authorization": f'Bearer {self.settings["api_key"]}'} | ||
self._torrents = {} | ||
# Realdebrid class library is a necessity | ||
while True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't agree with the continuous validation of RD. Since the app is meant for RD, would it be better to just exit the app if the first validation fails for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.