Skip to content

Commit

Permalink
[Explicit Module Builds] Remove dead/incorrect code for handling head…
Browse files Browse the repository at this point in the history
…er inputs of binary module dependencies

As of swiftlang/swift#72067, we instead serialize `.h` inputs directly into binary `.swiftmodule` files, because their clients may not be able to use the dependnecies' corresponding `.pch` files due to a compilation context mismatch. The clients of such binary modules then consume the serialized `.h` files directly, and compile them, implicitly, using explicit module dependencies collected during scan of such header files.

Resolves rdar://131261765
  • Loading branch information
artemcm committed Jul 8, 2024
1 parent 1567250 commit d7de803
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -269,12 +269,6 @@ public typealias ExternalTargetModuleDetailsMap = [ModuleDependencyId: ExternalT
if cas != nil && !prebuiltHeaderDependencyPaths.isEmpty {
throw DependencyScanningError.unsupportedConfigurationForCaching("module \(dependencyModule.moduleName) has bridging header dependency")
}

for headerDep in prebuiltHeaderDependencyPaths {
commandLine.appendFlags(["-Xcc", "-include-pch", "-Xcc"])
commandLine.appendPath(VirtualPath.lookup(headerDep.path))
inputs.append(TypedVirtualPath(file: headerDep.path, type: .pch))
}
}
for moduleArtifactInfo in clangDependencyArtifacts {
let clangModulePath =
Expand Down

0 comments on commit d7de803

Please sign in to comment.