Skip to content

import antt design icons using @ant-design/icons#4957

Open
pseudo-su wants to merge 1 commit intorjsf-team:mainfrom
pseudo-su:antd-svg-icons
Open

import antt design icons using @ant-design/icons#4957
pseudo-su wants to merge 1 commit intorjsf-team:mainfrom
pseudo-su:antd-svg-icons

Conversation

@pseudo-su
Copy link

@pseudo-su pseudo-su commented Feb 11, 2026

Reasons for making this change

this is the simplest fix to #4953, although depending on build tooling (tree shaking) it might lead to larger bundle sizes.

It looks like in the history of this project the SVG icons were converted to use the direct-imports approach here as part of an optimization effort.

For what it's worth, the @antd-design/icons readme on npm suggests that the imports should work both ways, so most likely there's something esoteric going on w/ how this project is bundling not being compatible w/ the default vite setup.


I've got a PR on my bug reproduction project to demonstrating this PR fixes the issue pseudo-su/vite-antd-rjsf-repro-4953#1

fixes #4953

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@heath-freenome
Copy link
Member

@pseudo-su Thanks for the fix. Can you please update the CHANGELOG.md to add the appropriate comment for the fix. Also you will have to rebase

@heath-freenome
Copy link
Member

@pseudo-su Just a little bit more work to get this over the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Antd ErrorList template causes runtime error when called if imported directly from the package

2 participants