import antt design icons using @ant-design/icons#4957
Open
pseudo-su wants to merge 1 commit intorjsf-team:mainfrom
Open
import antt design icons using @ant-design/icons#4957pseudo-su wants to merge 1 commit intorjsf-team:mainfrom
pseudo-su wants to merge 1 commit intorjsf-team:mainfrom
Conversation
This was referenced Feb 11, 2026
Antd ErrorList template causes runtime error when called if imported directly from the package
#4953
Open
Member
|
@pseudo-su Thanks for the fix. Can you please update the |
Member
|
@pseudo-su Just a little bit more work to get this over the line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
this is the simplest fix to #4953, although depending on build tooling (tree shaking) it might lead to larger bundle sizes.
It looks like in the history of this project the SVG icons were converted to use the direct-imports approach here as part of an optimization effort.
For what it's worth, the
@antd-design/iconsreadme on npm suggests that the imports should work both ways, so most likely there's something esoteric going on w/ how this project is bundling not being compatible w/ the default vite setup.I've got a PR on my bug reproduction project to demonstrating this PR fixes the issue pseudo-su/vite-antd-rjsf-repro-4953#1
fixes #4953
Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.