fix: preserve $ref in resolved schemas for recursive ui:definitions#4967
Merged
heath-freenome merged 2 commits intorjsf-team:mainfrom Feb 27, 2026
Merged
fix: preserve $ref in resolved schemas for recursive ui:definitions#4967heath-freenome merged 2 commits intorjsf-team:mainfrom
heath-freenome merged 2 commits intorjsf-team:mainfrom
Conversation
adamrimon
force-pushed
the
fix/lazy-ref-resolution
branch
from
5c3a875 to
5e779d0
Compare
adamrimon
force-pushed
the
fix/lazy-ref-resolution
branch
from
5e779d0 to
f538741
Compare
adamrimon
force-pushed
the
fix/lazy-ref-resolution
branch
from
822e58b to
5f749e9
Compare
…avoiding duplicate AJV validation errors
adamrimon
force-pushed
the
fix/lazy-ref-resolution
branch
3 times, most recently
from
0493d5c to
243bca6
Compare
heath-freenome
approved these changes
Feb 27, 2026
Member
heath-freenome
left a comment
heath-freenome
left a comment
There was a problem hiding this comment.
@adamrimon Thanks for the hard work on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixes #4966. In #4947 I accidentally missed committing a simple change in
resolveAllReferencesthat preserves$refas__rjsf_refon resolved schemas. Without it,resolveUiSchemacan't look upui:definitionsbeyond the first recursion level.Along with the fix, I added unit tests in
resolveUiSchema.test.tsand integration tests inuiSchema.test.tsxcoveringui:definitionswith recursive schemas including a 5-level recursive depth test.Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.