feat: autosave manually named sessions, #386 #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're using a manually named session (either through ':SessionSave mysession', `:SessionSearch`, or `:SessionRestore mysession`) then we'll now auto-save to that session on exit instead of always autosaving to the session derived from the cwd.
When auto-saving, if the session has been manually named use that session name instead of the cwd session name. Fixes manually named session not auto-saving on exit.
Turn off auto_create to make sure correct session name is checked when deciding to allow session saving or not
rmagatti
approved these changes
Oct 18, 2024
|
As a bonus, this also fixes #389 because it recognizes that the currently loaded session is manually named (i.e. it wasn't loaded from the cwd, including the currently checkout git branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should only impact manually named sessions, making them work more
how I think people would expect them to work.
If you're using a manually named session (either through ':SessionSave
mysession',
:SessionSearch, or:SessionRestore mysession) then we'llnow auto-save to that session on exit instead of always autosaving to
the session derived from the cwd.
Fixes #389