feat: extract markdown rendering from gh-slack #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extract the markdown conversion code from gh-slack to allow other clients to use it. It specifically focuses on converting an arbitrary string rather than a logical message. This part will be left to the client. It also makes the conversion more neutral and generic. Mostly copied from: - https://github.com/rneatherway/gh-slack/blob/main/internal/markdown/markdown.go - https://github.com/rneatherway/gh-slack/blob/main/internal/markdown/markdown_test.go
nobe4
added a commit
to nobe4/gh-slack
that referenced
this pull request
Apr 10, 2024
This is a companion PR that goes with rneatherway/slack#4 to showcase what changes will look like in the gh-slack client. It keeps the code as untouched as possible, and cleans the obsolete functions/types.
This was referenced Apr 10, 2024
rneatherway
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extract the markdown conversion code from gh-slack to allow other clients to use it. It specifically focuses on converting an arbitrary string rather than a logical message. This part will be left to the client.
It also makes the conversion more neutral and generic.
Mostly copied from:
cc rneatherway/gh-slack#65