Skip to content

Comments

release: v2023.3.3#1761

Merged
rustatian merged 2 commits intomasterfrom
release/v2023.3.3
Oct 26, 2023
Merged

release: v2023.3.3#1761
rustatian merged 2 commits intomasterfrom
release/v2023.3.3

Conversation

@rustatian
Copy link
Member

@rustatian rustatian commented Oct 26, 2023

Reason for This PR

  • Release day.

Description of Changes

🚀 v2023.3.3 [Bugfix] 🚀

🩹 Fixes

  • 🐛 RR Core: Fix removed by mistake RPC endpoint: ISSUE, (thanks @Kaspiman)

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

Release Notes:

  • Refactor: Removed the after_init configuration option from the server settings, simplifying the setup process.
  • Bug Fix: Addressed an issue in RR Core where a missing RPC endpoint was causing errors, improving system reliability.
  • Maintenance: Corrected an inaccurate log entry in the Temporal module, enhancing the accuracy of system diagnostics.
  • Chore: Implemented routine updates to various components and plugins, ensuring the software stays up-to-date and secure.

These changes aim to streamline the user experience, increase system reliability, and maintain the accuracy of system logs.

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. R-stable Release: Nominated for backporting to the RR in the stable channel. labels Oct 26, 2023
@rustatian rustatian requested a review from wolfy-j October 26, 2023 16:18
@rustatian rustatian self-assigned this Oct 26, 2023
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 26, 2023

Walkthrough

This update removes the after_init configuration from the server setup, indicating a refactoring or deprecation of this feature. It also includes a changelog detailing bugfixes and maintenance updates for the RR Core and Temporal module, respectively, across two versions.

Changes

File Summary
.rr.yaml Removed after_init configuration from the server setup, suggesting a refactoring or deprecation of this feature.
CHANGELOG.md Added updates for versions v2023.3.3 and v2023.3.2, detailing bugfixes for the RR Core and a maintenance update for the Temporal module.

🐇

"In the land of code, where the shadows lie,

An after_init was removed, with a sigh.

But fear not, for the changelog tells,

Of bugfixes and updates, like ringing bells.

So here's to the code, ever so bright,

Guiding us through the endless night." 🌙


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 795d29f and 6eddf55.
Files ignored due to filter (3)
  • go.mod
  • go.sum
  • schemas/config/3.0.schema.json
Files selected for processing (2)
  • .rr.yaml (1} hunks)
  • CHANGELOG.md (3} hunks)
Files skipped from review due to trivial changes (2)
  • .rr.yaml
  • CHANGELOG.md

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Qodana for Go

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1761 (0f1df91) into master (795d29f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1761   +/-   ##
=======================================
  Coverage   37.12%   37.12%           
=======================================
  Files          16       16           
  Lines         862      862           
=======================================
  Hits          320      320           
  Misses        516      516           
  Partials       26       26           

@rustatian rustatian merged commit b5acfd6 into master Oct 26, 2023
@rustatian rustatian deleted the release/v2023.3.3 branch October 26, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. R-stable Release: Nominated for backporting to the RR in the stable channel.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant