-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: flag to enable/disable experimental features #1762
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
WalkthroughThe codebase has been updated to include an experimental feature flag. This flag, when enabled, activates experimental features in the application. The changes have been implemented in the command functions and their corresponding tests, ensuring the new feature is well-integrated and thoroughly tested. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (2)
- go.mod
- go.sum
Files selected for processing (3)
- internal/cli/root.go (3 hunks)
- internal/cli/serve/command.go (3 hunks)
- internal/cli/serve/command_test.go (1 hunks)
Files skipped from review due to trivial changes (2)
- internal/cli/root.go
- internal/cli/serve/command_test.go
Additional comments: 2
internal/cli/serve/command.go (2)
24-24: The function signature has been changed to include an additional parameter
experimental *bool
. Ensure that all calls to this function throughout the codebase have been updated to match the new signature.47-47: The
ExperimentalFeatures
field in theconfigImpl.Plugin
struct is set based on the value of theexperimental
parameter. This is a good way to enable or disable experimental features.
Codecov Report
@@ Coverage Diff @@
## master #1762 +/- ##
==========================================
+ Coverage 37.12% 37.29% +0.17%
==========================================
Files 16 16
Lines 862 866 +4
==========================================
+ Hits 320 323 +3
- Misses 516 517 +1
Partials 26 26
|
Reason for This PR
Description of Changes
-e
: short form.--enable-experimental
: long form.License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.Summary by CodeRabbit
--enable-experimental
flag to enable experimental features. This new option allows users to test out upcoming features that are still in the experimental phase. Please note that these features may not be fully stable or complete. Use this flag with caution and at your own risk.--enable-experimental
flag. These changes ensure that our testing suite remains accurate and reliable as we introduce new features.