Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow to use env variable in schema properties #1768

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

cv65kr
Copy link
Member

@cv65kr cv65kr commented Nov 7, 2023

Reason for This PR

closes: #1586

Description of Changes

image image

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #1768 (9be224d) into master (fce8455) will not change coverage.
The diff coverage is n/a.

❗ Current head 9be224d differs from pull request most recent head a694b83. Consider uploading reports for the commit a694b83 to get more accurate results

@@           Coverage Diff           @@
##           master    #1768   +/-   ##
=======================================
  Coverage   37.29%   37.29%           
=======================================
  Files          16       16           
  Lines         866      866           
=======================================
  Hits          323      323           
  Misses        517      517           
  Partials       26       26           

@rustatian rustatian self-requested a review November 8, 2023 08:07
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Nov 8, 2023
Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @cv65kr

@rustatian rustatian merged commit 7fc0430 into roadrunner-server:master Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🧹 CHORE]: Improve validation schema for .rr.yml
2 participants