fix: correctly expand default bash env syntax

[rustatian]

Reason for This PR

closes: #1914

Description of Changes

• Use correct algorithm to expand default envs

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

• All commits in this PR are signed (git commit -s).
• The reason for this PR is clearly provided (issue no. or explanation).
• The description of changes is clear and encompassing.
• Any required documentation changes (code and docs) are included in this PR.
• Any user-facing changes are mentioned in CHANGELOG.md.
• All added/changed functionality is tested.

Summary by CodeRabbit

• Refactor
  • Updated to a newer version of the linting tool to enhance code quality checks.
  • Simplified linting rules by removing specific linters.
• New Features
  • Enhanced environment variable expansion capabilities in the application, supporting more complex configurations.

[coderabbitai]

Walkthrough

This update primarily enhances the handling of environment variables and configuration in a Go-based RPC client, improves linting settings, and updates dependencies. The changes introduce new utility functions for better variable parsing and expansion, streamline the linting process by removing certain linters, and upgrade the versions of the linting action and Go itself.

Changes

File Path	Change Summary
.github/workflows/tests.yml	Updated golangci-lint-action and Go version
.golangci.yml	Removed nestif, nlreturn, wsl linters
internal/rpc/client.go	Added/modified functions for enhanced env variable handling

Assessment against linked issues

Objective	Addressed	Explanation
#1914: rr workers/reset commands don't respect default config values	❌	The changes do not directly address the issue of respecting default config values in rr workers/reset commands.

Poem

🐇 Oh hop and code, we tweak and toil,
🌟 Upgrading lint, our code won't spoil.
With variables expanded, so neat and bold,
🚀 Enhancements made, stories retold.
In lines of Go, our changes set,
A rabbit's work, the best you'll get!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 277a6a9 and d1928dd.

Files ignored due to path filters (2)

• go.mod is excluded by !**/*.mod
• go.sum is excluded by !**/*.sum

Files selected for processing (3)

• .github/workflows/tests.yml (1 hunks)
• .golangci.yml (2 hunks)
• internal/rpc/client.go (3 hunks)

Files skipped from review due to trivial changes (1)

• .golangci.yml

Additional comments not posted (3)

.github/workflows/tests.yml (1)

42-44: Update to [email protected] and version v1.58 appears correctly implemented.

Ensure that the new linter version does not introduce any breaking changes or new linter errors that could affect the build.

internal/rpc/client.go (2)

21-22: Introduction of envDefault constant for handling default environment variables.

This change supports the new functionality for default value handling in environment variable expansion.

---

189-216: Enhancements to expandEnvViper function to handle different types of values.

The modifications support expanded functionality for environment variable handling in configurations, including strings and arrays of strings.
Ensure thorough testing to confirm that all supported value types are correctly handled and that no regressions have occurred in configuration parsing.