feature mx-1888 adds infobox to the ingest page

[eckelmannf]

PR Context

Added a type for the different aux values. Maybe its a bit overengineered but now u cant say sth like 'set_current_aux_provider("best_aux_ever")'. Would be lovely if we can achieve that the string "ldap", "orcid", "wikidata" are only written once (DRY). Only found a solution with an enum, which i didn't like.

Added

• infobox to ingest page for "ldap" and "wikidata"
• new type for aux_provider instead of str

Changes

• type of aux provider from str to AuxProvider

[cutoffthetop]

nice, congrats to your first mex pull request!

[cutoffthetop]

i know you wrote you didn't like enums, but i also think that's the only way of avoiding to write the strings more than once

class AuxProvider(Enum):
    """Allowed auxiliary providers."""
    LDAP = "ldap"
    ORCID = "orcid"
    WIKIDATA = "wikidata"

[cutoffthetop]

these new placeholders don't really fit in the width of the search box, could you either revert the change, shorten the placeholder text or widen the input element?

if you decide to keep them, you would need to update the failing test. but maybe it's more stable to match the input field by testid rather than by placeholder anyway.

so instead of page.get_by_placeholder("Search here...") you could use page.get_by_test_id("aux-search-input") and then add the testid to the input like this rx.input(..., custom_attrs={"data-testid": "aux-search-input"})

[eckelmannf]

I removed the dynamic placeholder stuff due to its not part of the ticket and i might have done a bit too much.

[cutoffthetop]

could you add a test in tests/ingest/test_main.py please to verify callouts (and placeholders) show the correct text for the selected provider? (at least for one or two of the providers)