Skip to content

"bad cookie" log levels warnings are inconsistent #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

"bad cookie" log levels warnings are inconsistent #819

wants to merge 1 commit into from

Conversation

gpotter2
Copy link
Contributor

@gpotter2 gpotter2 commented Mar 7, 2025

The other "bad cookie" warning is level 2:

masscan/src/main.c

Line 1061 in a31feaf

LOG(2, "%s - bad cookie: ackno=0x%08x expected=0x%08x\n",

this other one occurs in --banners, it makes sense for them to be consistent

@gpotter2 gpotter2 closed this Mar 7, 2025
@gpotter2 gpotter2 reopened this Mar 7, 2025
@gpotter2
Copy link
Contributor Author

gpotter2 commented Mar 7, 2025

Hi @p-l- @Frky , this is ready for review !

p-l-
p-l- approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@p-l- p-l- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-l- p-l- p-l- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpotter2 @p-l-