Fix panic when missing optional fields or descriptor after timezone #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DrAuYueng <[email protected]>
CybotTM
added a commit
to netresearch/go-cron
that referenced
this pull request
Nov 25, 2025
Bug robfig#554/robfig#555: TZ= parsing panic - Added bounds check for space index in timezone parsing - Returns error instead of panicking when spec has no fields after timezone - Added comprehensive tests for malformed timezone specs Bug robfig#551: Entry.Job.Run() bypasses chain decorators - Added Entry.Run() method that executes through WrappedJob - Ensures SkipIfStillRunning, DelayIfStillRunning, Recover are respected - Added tests validating chain behavior Tests: All new panic-prevention tests pass
CybotTM
added a commit
to netresearch/go-cron
that referenced
this pull request
Nov 25, 2025
- Update badges and import paths for the fork - Document panic fixes (issues robfig#554, robfig#555, robfig#551) - Document DST handling improvements (PR robfig#541) - Update Go version requirement to 1.25 - Simplify and modernize documentation structure
5 tasks
CybotTM
added a commit
to netresearch/go-cron
that referenced
this pull request
Nov 25, 2025
Modernize the robfig/cron fork with critical bug fixes and improvements. ## Bug Fixes - Fix TZ timezone parsing panic when spec has no fields after TZ prefix (robfig#554, robfig#555) - Fix nil pointer panic in Entry.Run() when WrappedJob is nil (robfig#551) ## Enhancements - Implement ISC cron DST behavior for spring forward (robfig#541) - Upgrade to Go 1.25 - Finalize module path as github.com/netresearch/go-cron ## CI/Quality - Add comprehensive GitHub Actions CI workflow - Add golangci-lint v2 configuration - Add Dependabot for dependency updates - Fix deprecated io/ioutil usage ## Documentation - Update README for fork with migration instructions - Document all fixes and improvements All tests pass. Successfully integrated into Ofelia with full test coverage.
CybotTM
added a commit
to netresearch/go-cron
that referenced
this pull request
Nov 26, 2025
Add comprehensive changelog following Keep a Changelog format: - Document all features added since fork from robfig/cron - List bug fixes for upstream issues robfig#551, robfig#554, robfig#555 - Include security improvements and validation changes - Add migration guide from robfig/cron - Document differences comparison table - Note planned v2 features Closes #22
3 tasks
CybotTM
added a commit
to netresearch/go-cron
that referenced
this pull request
Nov 26, 2025
Add comprehensive changelog following Keep a Changelog format: - Document all features added since fork from robfig/cron - List bug fixes for upstream issues robfig#551, robfig#554, robfig#555 - Include security improvements and validation changes - Add migration guide from robfig/cron - Document differences comparison table - Note planned v2 features Closes #22
CybotTM
added a commit
to netresearch/go-cron
that referenced
this pull request
Nov 28, 2025
Create docs/MIGRATION.md with detailed migration documentation: - Quick start section with import path and go.mod changes - Go version requirements comparison - Behavioral differences with before/after examples: - TZ= parsing panic fixes (robfig#554, robfig#555) - Entry.Run() chain behavior fix (robfig#551) - DST spring-forward handling (robfig#541) - Step range validation (robfig#543) - Input length limits - Type changes (EntryID: int -> uint64) - New features overview (FakeClock, StopAndWait, Timeout, heap scheduling) - Migration checklist - Testing recommendations with code examples - Troubleshooting section Also update README.md to link to the comprehensive migration guide. Closes #73
6 tasks
CybotTM
added a commit
to netresearch/go-cron
that referenced
this pull request
Nov 28, 2025
Create docs/MIGRATION.md with detailed migration documentation: - Quick start section with import path and go.mod changes - Go version requirements comparison - Behavioral differences with before/after examples: - TZ= parsing panic fixes (robfig#554, robfig#555) - Entry.Run() chain behavior fix (robfig#551) - DST spring-forward handling (robfig#541) - Step range validation (robfig#543) - Input length limits - Type changes (EntryID: int -> uint64) - New features overview (FakeClock, StopAndWait, Timeout, heap scheduling) - Migration checklist - Testing recommendations with code examples - Troubleshooting section Also update README.md to link to the comprehensive migration guide. Closes #73
4 tasks
|
Solution available in maintained fork This issue has been fixed in netresearch/go-cron, a maintained fork of this library. Fix: How to migrate: // Change import from:
import "github.com/robfig/cron/v3"
// To:
import cron "github.com/netresearch/go-cron"The API is 100% backward compatible. See the migration guide for details. Related: netresearch#31 |
|
@robfig PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #554.
Xref:kubernetes/kubernetes#134320