New ocr blocks #1430
Open
New ocr blocks #1430
+423
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lou-roboflow
requested review from
PawelPeczek-Roboflow,
grzegorz-roboflow,
yeldarby,
probicheaux and
hansent
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new EasyOCR block for extracting text from images using the EasyOCR Optical Character Recognition library. The implementation provides multi-language support and integrates with the existing workflow system.
- Implements a new EasyOCR block with support for 75+ character sets/languages
- Adds integration test with OCR text stitching workflow
- Registers the new block in the workflow system loader
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
inference/core/workflows/core_steps/models/third_party/easy_ocr/v1.py |
Core implementation of the EasyOCR block with manifest, character set mappings, and detection conversion logic |
inference/core/workflows/core_steps/loader.py |
Registration of the new EasyOCR block in the workflow system |
requirements/_requirements.txt |
Addition of easyocr dependency |
tests/workflows/integration_tests/execution/test_workflow_with_easy_ocr.py |
Integration test for EasyOCR functionality with text stitching |
Comments suppressed due to low confidence (1)
tests/workflows/integration_tests/execution/test_workflow_with_easy_ocr.py:44
- Function name is misleading - this test is for OCR workflow, not detection plus classification. Consider renaming to 'test_easy_ocr_workflow_when_minimal_valid_input_provided' or similar.
def test_detection_plus_classification_workflow_when_minimal_valid_input_provided(
inference/core/workflows/core_steps/models/third_party/easy_ocr/v1.py
Outdated
Show resolved
Hide resolved
…r/v1.py Remove print statement Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an EasyOCR block
Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Tested with various images, and execution test case included
Any specific deployment considerations
Included in block
Docs