Toast: Add progress and progress class support #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the improvement mentionned in #976.
This PR adds a progress bar under the Toast component when the progress variable is set to true like this :
$this->*toastType*(progress: true)When set to true, the progress bar will show up with the start value of 100, and decrease until 0 according to the duration of the toast, just like this :
Since the progress bar is the
<progress>component from DaisyUI, we can use the progress classes to customize the it with theprogressClassvariable like this :$this->*toastType*(progressClass: 'progress-primary')Note that
progressClassis set tonullby default, so the default color of the progress bar will be neutral.I also was wondering if
progressshould actually be in the default behaviour of the toast and set totrueby default instead offalse. Tell me what you think about it.(I'm aware that Livewire 4 is coming, making the merge of this PR delayed if validated)