Password improvements #953
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of the improvements for
passwordfields mentioned in #950.This PR supercedes #948 that was created concurrently, as it contains more than just addressing the mandatory tab-stop on password fields. Kudos to @themegazord for having the same idea as me (hence an obviously good one 😆) at the same time.
Among the other changes implemented, this aligns passwords with the styling logic of #920.
As a result, while it allows styling the fields in pretty much any desired way, at least AFAICT, it has the same small downsides as inputs (e.g. having to use
!importantclasses for the border of the disabled fields) and both inputs and passwords will need to be aligned to whatever behavior @robsontenorio wants in the future.The code:
results in:

Remember to change the focus on password fields by pressing tab, as this is very much included in the PR but does not render in a simple screenshot.
--
Closes #950
Closes #942