Skip to content

fix(test): check classifier model pattern for Azure OpenAI #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mainred
Copy link
Contributor

@mainred mainred commented Jun 7, 2025

By default, we want to share the llm model used for holmes and classifier, but the model used for Azure OpenAI follows the pattern azure/deployment-name, which cannot be passed to azure_deployment in openai.AzureOpenAI.
This PR extracts the deployment name from the model and validates the variable classifier_model follows the name pattern as MODEL

Copy link
Contributor

coderabbitai bot commented Jun 7, 2025

Walkthrough

The updates clarify documentation for the CLASSIFIER_MODEL environment variable, specifying supported LLM providers. In the code, stricter validation for Azure OpenAI classifier model identifiers is introduced, ensuring the correct format and extracting deployment names properly. Imports are also reorganized for clarity in the classifier utility test file.

Changes

File(s) Change Summary
docs/evals-introduction.md Updated documentation to specify supported LLM providers for the CLASSIFIER_MODEL environment variable.
tests/llm/utils/classifiers.py Reorganized imports; added validation for Azure OpenAI classifier model format; improved deployment name extraction.

Sequence Diagram(s)

sequenceDiagram
    participant TestRunner
    participant ClassifierUtils
    participant OpenAI
    participant AzureOpenAI

    TestRunner->>ClassifierUtils: Request classifier client (with classifier_model, base_url)
    alt base_url is set (Azure OpenAI)
        ClassifierUtils->>ClassifierUtils: Validate classifier_model format ("azure/<deployment-name>")
        ClassifierUtils->>AzureOpenAI: Create client using deployment name
    else base_url not set (OpenAI)
        ClassifierUtils->>OpenAI: Create client using classifier_model
    end
Loading

Suggested reviewers

  • aantn

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d23ed8 and 6622e69.

📒 Files selected for processing (2)
  • docs/evals-introduction.md (1 hunks)
  • tests/llm/utils/classifiers.py (1 hunks)
🔇 Additional comments (4)
docs/evals-introduction.md (1)

136-136: Documentation accurately reflects supported providers.

The clarification that CLASSIFIER_MODEL supports OpenAI and Azure OpenAI providers is helpful and aligns with the implementation changes.

tests/llm/utils/classifiers.py (3)

1-4: Import organization improvement.

The explicit imports at the top follow Python best practices and improve code readability.


14-17: Robust validation for Azure OpenAI classifier model format.

The validation correctly ensures that classifier_model follows the required "azure/" pattern when using Azure OpenAI. The error message is clear and helpful for debugging configuration issues.

The logic correctly:

  • Checks for exactly one slash (split length == 2)
  • Provides a descriptive error message
  • Only validates when base_url is set (Azure context)

20-20: Correct deployment name extraction for Azure OpenAI.

The split("/", 1)[1] correctly extracts the deployment name from the "azure/" pattern. Using split("/", 1) ensures that only the first slash is used for splitting, which handles edge cases where the deployment name might contain additional slashes.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant