-
Notifications
You must be signed in to change notification settings - Fork 102
fix(test): check classifier model pattern for Azure OpenAI #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe updates clarify documentation for the Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant ClassifierUtils
participant OpenAI
participant AzureOpenAI
TestRunner->>ClassifierUtils: Request classifier client (with classifier_model, base_url)
alt base_url is set (Azure OpenAI)
ClassifierUtils->>ClassifierUtils: Validate classifier_model format ("azure/<deployment-name>")
ClassifierUtils->>AzureOpenAI: Create client using deployment name
else base_url not set (OpenAI)
ClassifierUtils->>OpenAI: Create client using classifier_model
end
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
By default, we want to share the llm model used for holmes and classifier, but the model used for Azure OpenAI follows the pattern azure/deployment-name, which cannot be passed to azure_deployment in
openai.AzureOpenAI
.This PR extracts the deployment name from the model and validates the variable classifier_model follows the name pattern as MODEL