Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb context to handleIRC #20

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Plumb context to handleIRC #20

merged 2 commits into from
Mar 20, 2025

Conversation

slymas
Copy link
Contributor

@slymas slymas commented Mar 18, 2025

This should be useful to custom forks adding extra context-based logic to handleIRC

@stapelberg
Copy link
Contributor

The PR doesn’t seem to compile as-is, have you not tested it?

Error: robustirc-bridge/bridge.go:301:32: undefined: context

@slymas
Copy link
Contributor Author

slymas commented Mar 19, 2025

The PR doesn’t seem to compile as-is, have you not tested it?

Error: robustirc-bridge/bridge.go:301:32: undefined: context

I tested in another environment, which had the import in bridge.go without me realizing it. I pushed a new commit to add it here now. Sorry about that!

@stapelberg stapelberg merged commit 13f056a into robustirc:master Mar 20, 2025
9 checks passed
@slymas slymas deleted the patch-2 branch March 23, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants