Fix #106 #112
Merged
Fix #106 #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-4
commented
Apr 2, 2025
Anton-4
commented
Apr 3, 2025
Comment on lines
-12
to
-15
| expect "INFO: Checking if sqlite3 is installed...\r\n" | ||
|
|
||
| expect "3*" # sqlite3 version | ||
|
|
There was a problem hiding this comment.
This is no longer in the output.
Anton-4
commented
Apr 3, 2025
Comment on lines
+57
to
+65
|
|
||
| decode_db_status : Str -> Result TodoStatus _ | ||
| decode_db_status = |status_str| | ||
| when status_str is | ||
| "todo" -> Ok(Todo) | ||
| "completed" -> Ok(Completed) | ||
| "in-progress" -> Ok(InProgress) | ||
| _ -> Err(ParseError("Unknown status str: ${status_str}")) |
There was a problem hiding this comment.
To demonstrate the new map_value_result function.
…bserver into easier-sqlite-decoders
…bserver into easier-sqlite-decoders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function makes the situation described in #106 a lot nicer :)