Skip to content

Align with basic-cli: Http.send returns Result #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

Align with basic-cli: Http.send returns Result #113

merged 3 commits into from
Apr 4, 2025

Conversation

niclas-ahden
Copy link
Contributor

See: roc-lang/basic-cli#309

This is a breaking change.

niclas-ahden and others added 3 commits April 4, 2025 13:27
@niclas-ahden
Align with basic-cli: Http.send returns Result
03ab4f9 
See: roc-lang/basic-cli#309

This is a breaking change.
@niclas-ahden
Fix tests
61eda43 
`Http.get_utf8!` can now fail with an `HttpErr` during its request or
`BadBody` when decoding the response. We consolidate them into
`FetchErr Str` for this example; in line with the other functions here.
@niclas-ahden
Merge branch 'main' into http-align-with-basic-cli
46b08eb
Anton-4
Anton-4 approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @niclas-ahden!

@Anton-4 Anton-4 merged commit f48393a into roc-lang:main Apr 4, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-4 Anton-4 Anton-4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niclas-ahden @Anton-4