Url: Support URIs in query parameters #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query parameters should generally be percent-encoded but it's not required. Google's OAuth doesn't percent-encode their redirect URIs which prompted this PR.
Yes, that's the way to do it :) |
Anton-4
approved these changes
Apr 4, 2025
niclas-ahden
added a commit
to niclas-ahden/basic-cli
that referenced
this pull request
Apr 4, 2025
Align with `basic-webserver`: roc-lang/basic-webserver#115 Query parameters should generally be percent-encoded but it's not required. Google's OAuth doesn't percent-encode their redirect URIs which prompted this PR.
Anton-4
pushed a commit
to roc-lang/basic-cli
that referenced
this pull request
Apr 5, 2025
Align with `basic-webserver`: roc-lang/basic-webserver#115 Query parameters should generally be percent-encoded but it's not required. Google's OAuth doesn't percent-encode their redirect URIs which prompted this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query parameters should generally be percent-encoded but it's not required. Google's OAuth doesn't percent-encode their redirect URIs which prompted this PR.
Do we want
expectin the modules like this? It makes sense to me as both tests and documentation for curious users, but let me know if you'd prefer something else.If this gets merged I'll follow-up with an equivalent
basic-cliPR.