Basic canonicalize_expr of idents with tests #7806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamebox
requested review from
smores56 and
lukewilliamboswell
and removed request for
lukewilliamboswell
lukewilliamboswell
previously approved these changes
May 23, 2025
rtfeldman
reviewed
May 24, 2025
smores56
reviewed
May 25, 2025
smores56
reviewed
May 25, 2025
smores56
reviewed
May 27, 2025
smores56
reviewed
May 27, 2025
|
Ok, update on this. I've gone ham on getting it compiling and the test passing again. I haven't made a pass over the changes in any great depth yet. So I would consider this a WIP and not ready for merging right now. But it should be much easier to go through it now and fix issues. |
Comment on lines
+487
to
+505
| var items = collections.SafeList(CIR.Expr.Idx).initCapacity(self.can_ir.env.gpa, 0); | ||
| const items_slice = self.parse_ir.store.exprSlice(e.items); | ||
|
|
||
| for (items_slice) |item| { | ||
| if (self.canonicalize_expr(item)) |canonicalized| { | ||
| _ = items.append(self.can_ir.env.gpa, canonicalized); | ||
| } | ||
| } | ||
|
|
||
| const fresh_type_var = self.can_ir.type_store.fresh(); | ||
|
|
||
| // Mark the start of scratch expressions for the list | ||
| const scratch_top = self.can_ir.store.scratchExprTop(); | ||
|
|
||
| // Add all canonicalized items to scratch | ||
| var iter = items.iterIndices(); | ||
| while (iter.next()) |idx| { | ||
| self.can_ir.store.addScratchExpr(items.get(idx).*); | ||
| } |
There was a problem hiding this comment.
Is there a reason to have the allocation of items here? Can we just append straight to scratch?
const scratch_top = self.can_ir.store.scratchExprTop();
const items_slice = self.parse_ir.store.exprSlice(e.items);
for (items_slice) |item| {
if (self.canonicalize_expr(item)) |canonicalized| {
self.can_ir.store.addScratchExpr(canonicalized);
}
}
rtfeldman
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just me getting this started and sharing things so that I can make sure I understand what we are trying to accomplish correct.