Async: fix once_on_EVENT called more than once #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
once_on_XXXX was called more than once for events with a frequency higher than the eventloop.
|
Wouldn't the proper fix be to check for listening? at the point of call ? You could have the same effect on any on_* calls if the callback calls stop. |
|
Yes, the only problem is that the listeners get cloned. Therefore, I assume ObjectBase::process_event cannot handle this for all cases. That we could do is moving the check directly into the method EventListener::call and ignore all calls if the listener was stopped. |
I don't understand that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once_on_XXXX was called more than once for events with a frequency
higher than the eventloop.