drop master on /dev/dri/card0 by default #708
Open
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really odd edge case, but if you initialize a mpp buffer first and then later try to get the drm master to draw a user interface using another part of your program, you'll be unable to modeset.
This is because drm automatically sets the first file to open as the drm master.
Most people won't run into this issue (or I assume they won't) because they are already likely using a desktop environment (which will already claim the drm master), they are completely running as headless process, and/or they aren't initializing the mpp buffer before their UI.
I was lucky enough to have none of those as my setup, so ran head first into this problem.
The other way around this is to open a temporary file to /dev/dri/card0 before calling the mpp buffer code in your user code. I'm specifically using ffmpeg rockchip and running into this.
See also here: nyanmisaka#1