Removed Config and NetworkResources #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things we need to do is move
Resourcesaway from being a hardcoded construct and make it loadable on-disk. This prepares for that by removing it as an entity that the NMC config owns, and instead defers it to the downstream node implementer to provide. The implications to NMC itself are small, but there are larger ones for downstream projects like the Smart Node that need to be changed to fit this paradigm.The actual implementation of loading / providing Resources via custom structs or loading from disk will come soon; if you prefer we can wait for that before merging this PR and I'll just point to the commit directly for now.