Skip to content

Install zfs #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

AlanMarshall
Copy link
Contributor

This implements an openQA test to ensure that filesystem zfs can be installed under root xfs, and will operate correctly.

The test is included as part of FLAVOR universal used for release window testing and ongoing testing of system updates to ensure that zfs users will have a working filesystem following every individual change. It operates in uefi boot but with secure boot disabled because the zfs module taints the kernel.

The test saves a qcow2 file so that follow on tests can be added to implement further proposed feature tests.

Tested on Fedora 41:

./fifloader.py -c -l templates.fif.json
openqa-cli api -X POST isos ISO=Rocky-9.5-x86_64-dvd.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=9.5 CURRREL=9 LOCATION=https://dl.rockylinux.org/pub/rocky/9.5 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-universal-9.5 TEST=install_zfs

Result:
Pass
Screenshot 2025-01-09 at 19-40-59 openQA rocky-9 5-universal-x86_64-Build-20250109 192400 0-universal-9 5-install_zfs@64bit test results
Screenshot 2025-01-09 at 19-41-48 openQA rocky-9 5-universal-x86_64-Build-20250109 192400 0-universal-9 5-install_zfs@64bit test results

@AlanMarshall AlanMarshall requested review from tcooper and a team January 11, 2025 16:33
@AlanMarshall AlanMarshall added priority: medium This issue or pull request is of medium priority type: enhancement New feature or request type: test suite This issue or pull request is for test suite changes type: templates.fif.json Improvements or change to templates.fif.json labels Jan 11, 2025
@@ -88,6 +88,8 @@
"backend": "qemu",
"settings": {
"ARCH_BASE_MACHINE": "64bit",
"INSECURE_PFLASH_CODE": "/usr/share/edk2/ovmf/OVMF_CODE.fd",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are using UEFI=1 and UEFI_SECURE=1 in this machine definition and we have UEFI_PFLASH_{CODE|VARS} specified (below) do INSECURE_PFLASH_{CODE|VARS} do anything here? Are these lines leftover from the multiple commits / corrections to uefi machine while eventually arriving at using the 64bit machine for the ZFS tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. INSECURE_PFLASH_{CODE|VARS} is a carryover from templates in upstream os-autoinst-distri-fedora iirc (it's been a long time). I really should have removed it at the time and am quite happy to do it now.

@AlanMarshall AlanMarshall requested a review from tcooper April 3, 2025 13:09
@AlanMarshall
Copy link
Contributor Author

Tested 8.10 on Fedora 41:

./fifloader.py -c -l templates.fif.json
openqa-cli api -X POST isos ISO=Rocky-8.10-x86_64-dvd1.iso ARCH=x86_64 DISTRI=rocky FLAVOR=universal VERSION=8.10 CURRREL=8 BUILD=-"$(date +%Y%m%d.%H%M%S).0"-universal-8.10 TEST=install_zfs

Result:
Pass
Screenshot 2025-04-08 at 15-42-40 openQA rocky-8 10-universal-x86_64-Build-20250408 151913 0-universal-8 10-install_zfs@64bit test results

Screenshot 2025-04-08 at 15-45-00 openQA rocky-8 10-universal-x86_64-Build-20250408 151913 0-universal-8 10-install_zfs@64bit test results

Test of 9.5 repeated and result identical to previous as shown above.

Overall result: Pass

This configuration should also work for r10 when it comes.

@AlanMarshall
Copy link
Contributor Author

AlanMarshall commented Apr 8, 2025

@tcooper Further to discussion at the meeting I can see no way of avoiding hard coding latest major version as
zfs-release-2-3.el...
This actually installs 2.1.16 until I find a way of making it 2.3.2
If you know a way to avoid this hard coding, please let me know.

Otherwise this is ready for review.

@AlanMarshall
Copy link
Contributor Author

Looks like nobody is interested in this so it's goodnight Vienna.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This issue or pull request is of medium priority type: enhancement New feature or request type: templates.fif.json Improvements or change to templates.fif.json type: test suite This issue or pull request is for test suite changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants