Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

floehopper
Copy link

Description of the change

This improves the error handling - giving better visibility of things that might have gone wrong. In particular:

  • It now displays any error message returned in the response from Rollbar when the error code is not zero.
  • It now displays a message if the deploy_id cannot be extracted from the response from Rollbar; whereas previously it just silently failed.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • There don't appear to be any lint rules, so I haven't done anything about that.
  • There don't appear to be any tests, so I haven't done anything about that.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

@introkun introkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants