Skip to content

Comments

Amended PR: Add listen new config param "minimum_level" error log.#46

Open
ArturMoczulski wants to merge 14 commits intomasterfrom
listenNewConfigMinimumLevelError
Open

Amended PR: Add listen new config param "minimum_level" error log.#46
ArturMoczulski wants to merge 14 commits intomasterfrom
listenNewConfigMinimumLevelError

Conversation

@ArturMoczulski
Copy link

Amends #44

Test coverage for this is coming in #45

@Yozhef
Copy link

Yozhef commented Mar 24, 2019

@ArturMoczulski It's cool need now release rollbar-php =)

@Yozhef
Copy link

Yozhef commented May 18, 2019

@ArturMoczulski Hi, when will it be released?

enabled: true
access_token: ~ # pulled from phpunit.xml
environment: 'rollbar-php-symfony-test-app'
minimum_level: 'info' No newline at end of file
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an empty line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the reason this PR was never merged?

@jantenuccigsbla
Copy link

Hi @Yozhef this is great. when will it be released?

@Yozhef
Copy link

Yozhef commented Dec 18, 2019

@jantenuccigsbla sorry but I don't now need to ask @ArturMoczulski.

@javer
Copy link

javer commented Jan 11, 2020

I think we should also ask @jessewgibbs why library for Top PHP framework has such a low priority for Rollbar company.

Last release of this bundle was 1 year ago (2 Jan 2019). Now it doesn't support actual version of Rollbar library itself (v2). It doesn't support the actual version of Symfony framework (v5) which it is developed for. There is no tagged release even for recent already merged fixes. All proposed fixes by contributors are being considered for years.

What's the point to make official Symfony Bundle and don't support it for years? Don't Rollbar company really have enough money to hire one dedicated PHP developer for this library? Rollbar is a commercial product which is used by many companies including mine. Is it acceptable from the product point of view?

cc @ArturMoczulski @brianr @istvanerdo


before_install:
- composer self-update
- composer clear-cache
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made? Seems completely unnecessary.

Copy link

@Yozhef Yozhef Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The head is here:
Change:

        return new RollbarHandler(Rollbar::logger(), LogLevel::ERROR);
To:
        return new RollbarHandler(Rollbar::logger(), $this->minimumLevel);

Because there are errors above the error equation, but in the config, lib has params minimum erorr level log.

@Yozhef
Copy link

Yozhef commented Dec 15, 2020

I think this repository is dead = ( @ArturMoczulski if you don't want to do it, please pass it on to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants