Use mongo driver directly instead of Origin gem #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
reviewed
Jun 30, 2017
spec/unit/relation_spec.rb
Outdated
| to eql([{name: 'Jane',}, {name: 'Joe'}]) | ||
|
|
||
| expect(users.order(name: :desc).only(:name).without(:_id).to_a.map(&:to_h)). | ||
| expect(users.order(name: Mongo::Index::DESCENDING).only(:name).without(:_id).to_a.map(&:to_h)). |
There was a problem hiding this comment.
it'd be better if we hide this behind our API, so basically Mongo::Dataset#order could translate :desc and :asc to corresponding driver constants
|
Was this abandoned? 'Cause all that is making the checks fail is a change in ROM::CommandRegistry. |
|
@jfromell looks like it was |
|
I'm happy to continue work on this if you'd like. Let me know! |
|
The checks will pass again if you merge #25, so it's an easy fix. Any particular reason as to why that pull request hasn't been merged yet? |
|
@jfromell I don't know why this wasn't merged. I can keep working on it if the maintainers are interested in having me do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.